[PATCH] D46502: [ELF] - Fix for "LLD can create incorrect debug PC ranges for functions in Comdat groups."

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

In https://reviews.llvm.org/D46502#1095496, @ruiu wrote:

> I tried this patch locally, experimented some other ideas, and do some benchmark. My feeling is that this patch is too much as a workaround for a buggy input. This is too intrusive, and it creates too many objects at runtime. For instance, Firefox contains almost 1 million discarded comdat sections, and creating "proxy" objects for them isn't negligible. You probably should fix the compiler instead of implementing a workaround to the linekr.


Thanks for looking, Rui. I agree that it this functionality is too hacky probably.

Let's see for people other opinions. If there will be no strong arguments to do something like that in the linker, I'll abandon this patch then.


https://reviews.llvm.org/D46502