[llvm] r331841 - [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label.

[Hsiangkai Wang via llvm-commits]

On Fri, May 11, 2018 at 9:09 AM, Shiva Chen <shiva0217 at gmail.com> wrote:
> Hi Davide,
> The author is my colleague Hsiangkai.
> Let me transfer the email to him for more detail.
>
> Shiva
>
> 2018-05-11 3:46 GMT+08:00 Davide Italiano <davide at freebsd.org>:
>> On Tue, May 8, 2018 at 7:40 PM, Shiva Chen via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Author: shiva
>>> Date: Tue May  8 19:40:45 2018
>>> New Revision: 331841
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=331841&view=rev
>>> Log:
>>> [DebugInfo] Add DILabel metadata and intrinsic llvm.dbg.label.
>>>
>>
>> Hi Shiva,
>> this commit caused https://bugs.llvm.org/show_bug.cgi?id=37395.
>>
>> The issue here is in insertDebugValuesForPHIs().
>> A `DbgLabelInst` is-a `DbgInfoIntrinsic` but getVariableLocation()
>> hasn't been overridden for the class, so we end up crashing.
>> What do you think we should assign as variable location to
>> DbgLabelInst (if, we should)?
>>
>> Thanks,
>>
>> --
>> Davide

I think we should not assume DbgInfoIntrinsic has a 'variable location'
as its first operand. I will create a patch to fix the bug later.

Thanks,
Kai