[PATCH] D46672: COFF: ICF a section and its associated pdata section as a unit.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.

LGTM



================
Comment at: lld/COFF/ICF.cpp:153-154
+         A->Checksum == B->Checksum && A->getContents() == B->getContents() &&
+         (A->Pdata ? (B->Pdata && equalsConstant(A->Pdata, B->Pdata))
+                   : !B->Pdata);
 }
----------------
Maybe it is a bit cleaner if you simply pass A->Pdata and B->PData to equalsConstant (you would have to make a change to equalsConstant to allow a nullptr.)


https://reviews.llvm.org/D46672