[PATCH] D46731: Splitting thinlto.ll test file and renaming other test files.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/test/ELF/lto/thinlto-index-file.ll:10
+; RUN: ld.lld -m elf_x86_64 --plugin-opt=thinlto-index-only=%tlinkedobjfile -shared %t.o %t2.o %t4.o -o %t5
+; RUN: cat %tlinkedobjfile 2>&1 | FileCheck %s --check-prefix=IN1
+; IN1: {{.*}}thinlto-index-file.ll.tmp.o
----------------
Now that you have only one FileCheck, you can remove --check-prefix and replace IN1 with CHECK.

  FileCheck %s < %tlinkobjfile

is more straightforward than cat.

Please don't use a long file name because this file is short enough. %tlinkedobfile ->%t.idx



================
Comment at: lld/test/ELF/lto/thinlto-no-index.ll:4
+; Basic ThinLTO tests.
+; RUN: opt -module-summary %s -o %t.o
+; RUN: opt -module-summary %p/Inputs/thinlto.ll -o %t2.o
----------------
%t.o, %t2.o and %t4.o look a bit odd. Please rename them %t1.o, %t2.o and %t3.o.


================
Comment at: lld/test/ELF/lto/thinlto-obj-path.ll:9
+; RUN: ld.lld --plugin-opt=thinlto-index-only --plugin-opt=obj-path=%t4.o -shared %t.o %t2.o -o %t3
+; RUN: llvm-readobj -h %t4.o | FileCheck %s --check-prefix=FORMAT
+; RUN: llvm-nm %t4.o | count 0
----------------
Remove -check-prefix.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46731