[PATCH] D46723: Require GCC 5.0 and LLVM 3.4 at a minimum

[Erich Keane via Phabricator via llvm-commits]

erichkeane added a comment.

Additionally, IMO, I'd think we would be better off specifying Clang 3.5.  Being able to specify c++14 vs c++1y seems worth the minor inconvenience unless there is a platform we care about that ships 3.4.  FWIW, 5.1 supports c++14.



================
Comment at: cmake/modules/CheckCompilerVersion.cmake:11
     if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8)
-        message(FATAL_ERROR "Host GCC version must be at least 4.8!")
+      if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.0)
+        message(FATAL_ERROR "Host GCC version must be at least 5.0!")
----------------
If I recall correctly, 5.0 never existed as an official release.  5.0 would be GCC's development channel, so we likely want to specify 5.1 instead, right?


Repository:
  rL LLVM

https://reviews.llvm.org/D46723