[PATCH] D46661: [tsan] Add debugging API to retrieve the "external tag" from reports

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov accepted this revision.
george.karpenkov added a comment.
This revision is now accepted and ready to land.

LGTM, but would be better with a comment in the header describing the function



================
Comment at: lib/tsan/rtl/tsan_interface.h:122
+SANITIZER_INTERFACE_ATTRIBUTE
+int __tsan_get_report_tag(void *report, uptr *tag);
+
----------------
kubamracek wrote:
> delcypher wrote:
> > There's no documentation on the meaning of the arguments or the return value here.
> > 
> See comments around. "report" is an opaque pointer representing the report we want to extract data from, "tag" is the output variable. All these APIs return non-zero on success, zero on failure.
> 
> Sorry about the lack of formal documentation here, it's because this is only for debugger integration (and not really a public API) and this header file isn't shipped anywhere.
I would also prefer a basic doxygen comment.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D46661