[PATCH] D46703: [MC] Relax .fill size requirements

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:646-652
   if (!NumValues.evaluateAsAbsolute(IntNumValues, getAssemblerPtr())) {
+    // Byte fills don't need to know NumValues.
+    if (Size == 1) {
+      emitFill(NumValues, Expr, Loc);
+      return;
+    }
+
----------------
Would it be cleaner to generalize `MCFillFragment` and then we could defer this label difference calculation until after relaxation?


================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:3144
   getStreamer().emitFill(*NumValues, FillSize, FillExpr, NumValuesLoc);
-
   return false;
----------------
Given that this is the only change in the file, I'd revert it.


Repository:
  rL LLVM

https://reviews.llvm.org/D46703