[PATCH] D46502: [ELF] - Fix for "LLD can create incorrect debug PC ranges for functions in Comdat groups."

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

In https://reviews.llvm.org/D46502#1094678, @grimar wrote:

> In https://reviews.llvm.org/D46502#1094663, @ruiu wrote:
>
> > I don't think there's a hack that you can easily remove. Once something lands to the linker's source code, that becomes a part of the implicit ABI, and you can never remove it unless it becomes really obsolete. Basically, you should assume that landing some feature or a workaround is a commitment that we will very likely to keep it for a long period of time.
>
>
> I like this position. Then my question is do we want it? I feel it is a dirty hack. I do not know how much it is important to have/do not have for us though.


I don't have a strong position, I happened to notice that gold and bfd had implemented some method to patch up relocations to local symbols in groups. I think that this actually started in BFD to work around bugs in gcc linkonce sections : https://sourceware.org/bugzilla/show_bug.cgi?id=233 however it looks to have been altered over time to only affect .debug sections and I haven't been able to find any source code commit messages that say why.


https://reviews.llvm.org/D46502