[PATCH] D46693: lld-link: Add --color-diagnostics(={always, never, auto})?, --no-color-diagnostics flags.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 10:05:42 PDT 2018


thakis added a comment.

In https://reviews.llvm.org/D46693#1094466, @ruiu wrote:

> Is there any reason to make it exactly the same option name as Unix linkers? I mean, all the other options in the COFF linker are Windows-ish, e.g. /something. So I wonder if /colordiagnostics{,:always,:never,:auto} is better.


For flags that link.exe doesn't have and that are shared with ld.lld, I thought we usually use the -- prefix to reduce the risk of collision with future link.exe flags, and for consistency (cf --version, --rsp-quoting).

(Will fix the nits, also in the ELF and wasm versions.)


https://reviews.llvm.org/D46693





More information about the llvm-commits mailing list