[PATCH] D45788: Mitigate relocation overflow [part 1 of 2]

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 08:24:48 PDT 2018


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

I do not know what is wrong, but the following tests are still failing for me.

30>  Failing Tests (5):
30>      lld :: ELF/aarch64-copy.s
30>      lld :: ELF/arm-copy.s
30>      lld :: ELF/note-noalloc.s
30>      lld :: ELF/relocation.s
30>      lld :: ELF/version-script-extern.s

`note-noalloc.s` is a new one, you have to update it, but others are old and I see you already updated them in the patch,
they seem to be trivial, so not sure what is wrong here, please check your configuration because I tested on 2 and result was the same.

The rest of changes looks fine to me mostly I think (I'll probably adjust few minor things after your commit).

I do not want to be a stopper for this one anymore, so please feel free to commit after fixing above tests.
And let's see how this change works in practice.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45788





More information about the llvm-commits mailing list