[PATCH] D46616: [AMDGPU][Waitcnt] Fix handling of flat instrs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 10 04:53:30 PDT 2018


arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/waitcnt.mir:33-37
-# CHECK: S_WAITCNT 368
+# CHECK: S_WAITCNT 112
 # CHECK: FLAT_LOAD_DWORDX4
-# The first load has no mem operand, so we should assume it accesses the flat
-# address space.
-# s_waitcnt lgkmcnt(1)
----------------
Since this is a change for a specific subtarget, should this test have multiple sets of check lines instead of just changing these


https://reviews.llvm.org/D46616





More information about the llvm-commits mailing list