[PATCH] D46566: Add a CIE with length 0 unconditionally.

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

I would like tounderstand why this is needed.
You wrote: "This is not technically required, but glibc unwind-dw2-fde.c classify_object_over_fdes expects there is a CIE record length 0 as a terminator.".

Can you please point me on a line of code in glibc that needs this change in the linker? What is the current behavior of LLD linked binaries?



================
Comment at: ELF/SyntheticSections.cpp:502
+  // classify_object_over_fdes expects there is a CIE record length 0 as a
+  // terminator. Thus we add one unconditionally.
+  Off += 4;
----------------
I think would be nice for that comment to contain some additional information, like:
1) A version of glibc code this code is targeted to fix.
2) Current date at which we are observing the issue.
3) Reference to a corresponding bug in their bug tracker.
4) Maybe information about what GNU linkers do can be also useful to have.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46566