[PATCH] D46512: [ARM] Add support for SETCCCARRY instead of SETCCE

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:1068
   // Thumb-1 cannot currently select ARMISD::SUBE.
   if (!Subtarget->isThumb1Only())
+    setOperationAction(ISD::SETCCCARRY, MVT::i32, Custom);
----------------
efriedma wrote:
> Do we still need the Thumb1Only check here?  I thought we fixed that.  But I guess we can change that as a followup.
I honestly do not know.


================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:10342
   SelectionDAG &DAG(DCI.DAG);
-
   if (N->getOpcode() == ARMISD::SUBC) {
----------------
efriedma wrote:
> Whitespace change?
I will revert this.


Repository:
  rL LLVM

https://reviews.llvm.org/D46512