[PATCH] D46608: Add support for ThinLTO plugin option thinlto-object-suffix-replace

Rumeet Dhindsa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 13:32:15 PDT 2018


rdhindsa added inline comments.


================
Comment at: lld/ELF/InputFiles.cpp:1030-1033
+  if (Config->ThinLTOIndexOnly) {
+    Path.consume_back(Config->ThinLTOObjectSuffixReplace.first.str());
+    UpdatedPath = Path.str() + Config->ThinLTOObjectSuffixReplace.second.str();
+  }
----------------
ruiu wrote:
> All tests including the new one you are adding in this patch seem to pass without these four lines of code. Is this needed?
Yeah it is needed as this handles all the bitcode files except lazyobjfiles. I verified that the test thinlto-object-suffix-replace fails without these changes.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46608





More information about the llvm-commits mailing list