[PATCH] D44623: Fix asan on i?86-linux (32-bit) against glibc 2.27 and later

Jakub JelĂ­nek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 09:05:43 PDT 2018


jakubjelinek added a comment.

Updated patch, which uses a template with 2 support classes to avoid some code duplication.  I must say that I find

  #ifndef __GLIBC_PREREQ
  # define __GLIBC_PREREQ(x, y) 0
  #endif

easier to read over the longer sequence of #ifs, and as I said earlier, the proposed

  #if defined(__i386__) && (!defined(__GLIBC_PREREQ) || !__GLIBC_PREREQ(2, 27))

is not valid C/C++ if __GLIBC_PREREQ macro is not defined.


Repository:
  rL LLVM

https://reviews.llvm.org/D44623





More information about the llvm-commits mailing list