[PATCH] D41953: [LoopUnroll] Unroll and Jam

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: test/Transforms/LoopUnrollAndJam/unprofitable.ll:226
+
+attributes #0 = { noinline norecurse nounwind "correctly-rounded-divide-sqrt-fp-math"="false" "denormal-fp-math"="preserve-sign" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="true" "no-jump-tables"="false" "no-nans-fp-math"="true" "no-signed-zeros-fp-math"="true" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="cortex-m33" "target-features"="+d16,+dsp,+fp-armv8,+fp-only-sp,+hwdiv,+thumb-mode,-crc,-dotprod,-hwdiv-arm,-ras" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind }
----------------
Nit: do you need all this?


================
Comment at: test/Transforms/LoopUnrollAndJam/unroll-and-jam.ll:9
+; CHECK: entry:
+; CHECK:   br i1 %or.cond, label %for.outer.preheader, label %for.end
+; CHECK: for.outer.preheader:
----------------
Do we need all these checks? And with all the variable names still there, it looks like a fragile test to me. Same for the other functions below.


https://reviews.llvm.org/D41953