[PATCH] D46591: [AArch64] Fix performPostLD1Combine to check for constant lane index.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 9 02:14:43 PDT 2018


samparker added inline comments.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:9938
+    Lane = N->getOperand(2);
+    if (!isa<ConstantSDNode>(Lane))
+      return SDValue();
----------------
Should the value of Lane also be checked for legality?


Repository:
  rL LLVM

https://reviews.llvm.org/D46591





More information about the llvm-commits mailing list