[PATCH] D46620: Fix side effect in debug code

Zachary Turner via llvm-commits llvm-commits at lists.llvm.org
Tue May 8 19:23:10 PDT 2018


It actually looks wrong to me to *not* have the side effect. If this is due
to some warning, then the increment needs to be moved after the assert
On Tue, May 8, 2018 at 7:18 PM George Burgess IV via Phabricator <
reviews at reviews.llvm.org> wrote:

> george.burgess.iv added a comment.
>
> I don't know this code well enough to LGTM this, but can you talk a bit
> about why, please? This side-effect-inside-an-assert looks sane to me.
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D46620
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180509/0d5c8418/attachment.html>


More information about the llvm-commits mailing list