[PATCH] D46414: [GlobalISel][Legalizer] More concise and faster widenScalar, NFC

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin marked 3 inline comments as done.
rtereshin added a comment.

@aditya_nandakumar Yes, I do have my doubts that the original implementation with sign extension is always correct, but it's NFC here anyway. I'm thinking to take a look at it at some point and see if I can come up with a breaking test case for that sign extend.

I'm also worried about how we legalize some "generic-generic" opcodes, like `G_PHI` - the ones that are supposedly universal and can handle floating point values and integer values both - if we always `G_TRUNC`ate them, for instance, how is it going to inter-operate with floating point values and floating point opcodes?

Thank you for looking into this,
Roman


Repository:
  rL LLVM

https://reviews.llvm.org/D46414