[PATCH] D46567: [llvm-strip] Add support for -remove-section

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich added inline comments.


================
Comment at: test/tools/llvm-objcopy/remove-section.test:2
 # RUN: yaml2obj %s > %t
+# RUN: cp %t %t1
 # RUN: llvm-objcopy -R .test2 %t %t2
----------------
alexshap wrote:
> jakehehrlich wrote:
> > nit: I'd prefer not to copy in this case
> i copied because potentially llvm-objcopy can modify the input (i.e. by mistake),
> it's not the case here, but my motivation was to reduce the room for potential interfering of different runs.
Ah, in that case can you add a check after the first objcopy to check that %t and %t1 are binary equivalent after the first call to objcopy? That way we can detect that case if it occurs.


Repository:
  rL LLVM

https://reviews.llvm.org/D46567