[PATCH] D45642: [PPC64] V2 abi: Add glink section for lazy symbol resolution.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked 4 inline comments as done.
sfertile added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1927
+    : SyntheticSection(SHF_ALLOC | SHF_EXECINSTR, SHT_PROGBITS, 16,
+                      Config->EMachine == EM_PPC64 ? ".glink" : ".plt"),
       HeaderSize(IsIplt ? 0 : Target->PltHeaderSize), IsIplt(IsIplt) {
----------------
ruiu wrote:
> Indentation
I believe the indentation here is correct. The line I added is an argument to the SyntheticSection constructor so it lines up with the first arg on the previous line. The following line is a different member initializer and so it lines up with the SyntheticSection constructor. 


================
Comment at: ELF/SyntheticSections.cpp:926
                        Target->GotPltEntrySize,
-                       Config->EMachine == EM_ARM ? ".got" : ".got.plt") {}
+                       Config->EMachine == EM_ARM ? ".got" :
+                       Config->EMachine == EM_PPC64 ? ".plt" :
----------------
I used clang-format on this but didn't like the result:

```
                       Config->EMachine == EM_ARM
                           ? ".got"
                           : Config->EMachine == EM_PPC64 ? ".plt"
                                                          : ".got.plt") {}

```

So I manually formatted, does anyone have a preference on this?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45642