[llvm] r330742 - Let TableGen write output only if it changed, instead of doing so in cmake.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 19:33:51 PDT 2018


I reverted this in r330742. That said, I really am happy to see another
attempt here. I actually tried several things myself to get it to work and
failed. I'm not sure what the magical difference is at this point.

On Mon, May 7, 2018 at 7:21 PM Dean Michael Berris <dberris at google.com>
wrote:

> +1 to this, either we fix this or can we revert?
> On Tue, May 8, 2018 at 9:39 AM Chandler Carruth via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> > On Fri, May 4, 2018 at 4:47 AM Tim Northover via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
> >> Hi Nico,
>
> >> On 24 April 2018 at 18:29, Nico Weber via llvm-commits
> >> <llvm-commits at lists.llvm.org> wrote:
> >> > Let TableGen write output only if it changed, instead of doing so in
> cmake.
>
> >> This change seems to force all TableGen steps to rerun even for an
> >> incremental build with no changes. That's probably worse than the
> >> status before. Do you think it's fixable?
>
>
> > I think this has to be fixed.
>
> > Running tablegen is *not fast* in many cases. Re-running it for every
> target for every rebuild is really not acceptable.
>
> > Nico, it's been over a week with no update. I'm going to revert this
> until you have time to look into fixing this because myself and numerous
> other people have been complaining about constant rebuilds due to this and
> not know why this happens.
>
>
>
> >> Cheers.
>
> >> Tim.
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at lists.llvm.org
> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180508/5f1e5f66/attachment.html>


More information about the llvm-commits mailing list