[PATCH] D46564: [SSAUpdaterBulk] Sort blocks in IDF to avoid non-determinism.

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 17:26:29 PDT 2018


mzolotukhin added a comment.

Hi,

This patch includes two pieces: fixing non-determinism in `SSAUpdaterBulk` and enabling it in JumpThreading. When approved, I'll commit them separately, but I included them both here for convenience. The fix for `SSAUpdaterBulk` requires basic-block enumeration, which should be passed from the `SSAUpdaterBulk` user, and thus it incurs the corresponding changes in JumpThreading. I'm not a big fan of an extra parameter in `RewriteAllUses` function and will be happy to discuss alternative, but for now I followed an example from MemorySSA. What do you think?

Thanks,
Michael


Repository:
  rL LLVM

https://reviews.llvm.org/D46564





More information about the llvm-commits mailing list