[PATCH] D46478: [Coverage] Do not skip functions with the same name when loading CoverageMapping.

[Max Moroz via Phabricator via llvm-commits]

Dor1s added a comment.

Thanks Vedant! The following tests trigger that branch:

  LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0
  LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/1
  LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/2
  LLVM-Unit :: ProfileData/./ProfileDataTests/ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/3
  LLVM :: tools/llvm-cov/load-multiple-objects.test
  LLVM :: tools/llvm-cov/multiple-objects.test
  LLVM :: tools/llvm-cov/universal-binary.c

And the first 4 actually fail with my change. Looks like I've tested something wrong previously (I think I did only `check-llvm-tools` rather then `check-llvm`), my bad. I'm looking into those tests now to see their purpose.


Repository:
  rL LLVM

https://reviews.llvm.org/D46478