[PATCH] D46544: Set DF_TEXTREL only if text relocations are really needed.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 14:01:34 PDT 2018


ruiu added a comment.

I don't know if setting DF_TEXTREL flag only when text relocation is actually needed is a right solution to solve the issue you described. In lld, when you pass `-z textrel`, we should assume that the program really needs a text relocations, because otherwise you wouldn't pass that flag to the linker. If it is not compatible with IFUNC, we should emit a warning when we find a IFUNC symbol, no?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46544





More information about the llvm-commits mailing list