[PATCH] D46544: Set DF_TEXTREL only if text relocations are really needed.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

This is perhaps harmless, but I'm leaning towards not doing this unless there's a reason to do this. I understand why GNU linkers want to do this -- it is because they allow text relocations by default. On the other hand, lld sets DF_TEXTREL only when you explicitly make lld allow text relocations. So, simply setting the flag when the flag is given makes sense to me. Can I ask your motivation of making this change?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46544