[PATCH] D46539: [X86] ptwrite intrinsic

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/X86.td:623
   ProcIntelGLM,
   FeaturePOPCNTFalseDeps
 ]>;
----------------
Just put FeaturePTWRITE here?


================
Comment at: test/CodeGen/X86/ptwrite-intrinsic-x86.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc < %s -mtriple=i386-unknown-unknown -mattr=+ptwrite | FileCheck %s
+
----------------
Possibly test all the i32 versions here on both x86/x64 and just test the i64 versions in the x86_64.ll file.


================
Comment at: test/CodeGen/X86/ptwrite-intrinsic-x86.ll:12
+  ret void
+}
+
----------------
Can you add tests for the reg-reg version as well?


https://reviews.llvm.org/D46539