[PATCH] D46367: [llvm-mca] Avoid exposing index values in the MCA interfaces.

[Matt Davis via Phabricator via llvm-commits]

mattd added a comment.

Thanks for the review!



================
Comment at: tools/llvm-mca/Instruction.h:20
 #include "llvm/Support/MathExtras.h"
+#include "llvm/Support/raw_ostream.h"
 #include <memory>
----------------
andreadb wrote:
> I still think you should remove this include. It is only there because of method print, which should be also guarded against NDEBUG.
I get build errors regarding raw_stream if the header is not there for debug builds, so I think it needs to stay, at least to support the overloaded output operator.  I could guard the include directive; however, I don't see anywhere in the compiler that specifically guards against that header.


https://reviews.llvm.org/D46367