[llvm] r331650 - [DAGCombine][NFC] Masked merge unfolding: comment: some tests are non-canonical

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Mon May 7 09:42:47 PDT 2018


Author: lebedevri
Date: Mon May  7 09:42:47 2018
New Revision: 331650

URL: http://llvm.org/viewvc/llvm-project?rev=331650&view=rev
Log:
[DAGCombine][NFC] Masked merge unfolding: comment: some tests are non-canonical

As requested in https://reviews.llvm.org/D46494#inline-407282

Modified:
    llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll
    llvm/trunk/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll

Modified: llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll?rev=331650&r1=331649&r2=331650&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll (original)
+++ llvm/trunk/test/CodeGen/AArch64/unfold-masked-merge-scalar-variablemask.ll Mon May  7 09:42:47 2018
@@ -355,6 +355,7 @@ define i32 @in_constant_varx_mone(i32 %x
   %r = xor i32 %n1, -1
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: out_constant_varx_mone_invmask:
 ; CHECK:       // %bb.0:
@@ -367,6 +368,7 @@ define i32 @out_constant_varx_mone_invma
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: in_constant_varx_mone_invmask:
 ; CHECK:       // %bb.0:
@@ -407,6 +409,7 @@ define i32 @in_constant_varx_42(i32 %x,
   %r = xor i32 %n1, 42
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: out_constant_varx_42_invmask:
 ; CHECK:       // %bb.0:
@@ -421,6 +424,7 @@ define i32 @out_constant_varx_42_invmask
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: in_constant_varx_42_invmask:
 ; CHECK:       // %bb.0:
@@ -458,6 +462,7 @@ define i32 @in_constant_mone_vary(i32 %x
   %r = xor i32 %n1, %y
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: out_constant_mone_vary_invmask:
 ; CHECK:       // %bb.0:
@@ -470,6 +475,7 @@ define i32 @out_constant_mone_vary_invma
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: in_constant_mone_vary_invmask:
 ; CHECK:       // %bb.0:
@@ -510,6 +516,7 @@ define i32 @in_constant_42_vary(i32 %x,
   %r = xor i32 %n1, %y
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: out_constant_42_vary_invmask:
 ; CHECK:       // %bb.0:
@@ -524,6 +531,7 @@ define i32 @out_constant_42_vary_invmask
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-LABEL: in_constant_42_vary_invmask:
 ; CHECK:       // %bb.0:

Modified: llvm/trunk/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll?rev=331650&r1=331649&r2=331650&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll (original)
+++ llvm/trunk/test/CodeGen/X86/unfold-masked-merge-scalar-variablemask.ll Mon May  7 09:42:47 2018
@@ -578,6 +578,7 @@ define i32 @in_constant_varx_mone(i32 %x
   %r = xor i32 %n1, -1
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: out_constant_varx_mone_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -598,6 +599,7 @@ define i32 @out_constant_varx_mone_invma
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_varx_mone_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: in_constant_varx_mone_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -666,6 +668,7 @@ define i32 @in_constant_varx_42(i32 %x,
   %r = xor i32 %n1, 42
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: out_constant_varx_42_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -689,6 +692,7 @@ define i32 @out_constant_varx_42_invmask
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_varx_42_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: in_constant_varx_42_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -750,6 +754,7 @@ define i32 @in_constant_mone_vary(i32 %x
   %r = xor i32 %n1, %y
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: out_constant_mone_vary_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -772,6 +777,7 @@ define i32 @out_constant_mone_vary_invma
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_mone_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: in_constant_mone_vary_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -836,6 +842,7 @@ define i32 @in_constant_42_vary(i32 %x,
   %r = xor i32 %n1, %y
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @out_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: out_constant_42_vary_invmask:
 ; CHECK-NOBMI:       # %bb.0:
@@ -860,6 +867,7 @@ define i32 @out_constant_42_vary_invmask
   %r = or i32 %mx, %my
   ret i32 %r
 }
+; This is not a canonical form. Testing for completeness only.
 define i32 @in_constant_42_vary_invmask(i32 %x, i32 %y, i32 %mask) {
 ; CHECK-NOBMI-LABEL: in_constant_42_vary_invmask:
 ; CHECK-NOBMI:       # %bb.0:




More information about the llvm-commits mailing list