[PATCH] D46457: [asan] Add a magic shadow value for shadw gap

[Walter Lee via Phabricator via llvm-commits]

waltl updated this revision to Diff 145473.
waltl added a comment.

Address CR comments


Repository:
  rL LLVM

https://reviews.llvm.org/D46457

Files:
  compiler-rt/lib/asan/asan_errors.cc
  compiler-rt/lib/asan/asan_internal.h


Index: compiler-rt/lib/asan/asan_internal.h
===================================================================
--- compiler-rt/lib/asan/asan_internal.h
+++ compiler-rt/lib/asan/asan_internal.h
@@ -147,6 +147,9 @@
 const int kAsanIntraObjectRedzone = 0xbb;
 const int kAsanAllocaLeftMagic = 0xca;
 const int kAsanAllocaRightMagic = 0xcb;
+// Used to populate the shadow gap for systems without memory
+// protection there (i.e. Myriad).
+const int kAsanShadowGap = 0xcc;
 
 static const uptr kCurrentStackFrameMagic = 0x41B58AB3;
 static const uptr kRetiredStackFrameMagic = 0x45E0360E;
Index: compiler-rt/lib/asan/asan_errors.cc
===================================================================
--- compiler-rt/lib/asan/asan_errors.cc
+++ compiler-rt/lib/asan/asan_errors.cc
@@ -514,6 +514,7 @@
   PrintShadowByte(str, "  ASan internal:           ", kAsanInternalHeapMagic);
   PrintShadowByte(str, "  Left alloca redzone:     ", kAsanAllocaLeftMagic);
   PrintShadowByte(str, "  Right alloca redzone:    ", kAsanAllocaRightMagic);
+  PrintShadowByte(str, "  Shadow gap:              ", kAsanShadowGap);
 }
 
 static void PrintShadowBytes(InternalScopedString *str, const char *before,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46457.145473.patch
Type: text/x-patch
Size: 1189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180507/6a34c954/attachment.bin>