[PATCH] D46417: wasm: Add a flag to control merging data segments

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 17:20:08 PDT 2018


sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:861
 static StringRef getOutputDataSegmentName(StringRef Name) {
   if (Config->Relocatable)
     return Name;
----------------
I did some experimenting with this locally and it looks like the better solution here is to change the above line to `if (!Config->MergeDataSegments)`. 

Then you don't need the below change.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D46417





More information about the llvm-commits mailing list