[PATCH] D46470: [AMDGPU] Fixed a couple of SIFixWWMLiveness problems

Connor Abbott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 14:56:26 PDT 2018


cwabbott added a comment.

For the liveness issue, maybe a better way to solve it would be to add a new ENTER_WWM pseudoinstruction similar to EXIT_WWM, and add a matching implicit def to the matching ENTER_WWM whenever we insert an implicit use on EXIT_WWM, and mark both of them as kills. After all, any affected registers only need to interfere with the instructions run in WWM, so that should help with code quality too. I'm not sure why I didn't do that in the first place.


Repository:
  rL LLVM

https://reviews.llvm.org/D46470





More information about the llvm-commits mailing list