[PATCH] D46469: [sanitizer] Port fast stack unwinder to sparcv8

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 14:20:35 PDT 2018


kcc added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cc:74
   if (stack_top < 4096) return;  // Sanity check for stack top.
+#if defined(__sparcv8__)
+  // Flush register windows to memory
----------------
This code is already too complex and fragile. Please avoid any #ifdefs
One option is to fork this function into a sparc-specific file. 


Repository:
  rL LLVM

https://reviews.llvm.org/D46469





More information about the llvm-commits mailing list