[PATCH] D46211: [LICM] Compute a must execute property for the prefix of the header as we go

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: lib/Transforms/Scalar/LICM.cpp:508
+               CurLoop->getLoopPreheader()->getTerminator())))
         Changed |= hoist(I, DT, CurLoop, SafetyInfo, ORE);
+
----------------
mkazantsev wrote:
> If hoist was successful, we don't actually need to make `isGuaranteedToTransferExecutionToSuccessor` check on the instruction that is no longer in this block. Maybe replace with assert in this case?
I need to add a continue after the hoist.  (In theory, we hoist instructions that aren't guaranteed to transfer control to their successors - we don't today, but might.)  Will fix.


Repository:
  rL LLVM

https://reviews.llvm.org/D46211