[PATCH] D45118: Linking debug (DWARF) sections from the WebAssembly object files

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 12:06:28 PDT 2018


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: wasm/InputFiles.cpp:80
+  case R_WEBASSEMBLY_SECTION_OFFSET_I32: {
+    auto *Sym = cast<SectionSymbol>(getSectionSymbol(Reloc.Index));
+    return Sym->Section->OutputOffset + Reloc.Addend;
----------------
No need for this cast anymore


================
Comment at: wasm/InputFiles.cpp:156
+  case R_WEBASSEMBLY_SECTION_OFFSET_I32:
+    if (auto *Sym = dyn_cast<SectionSymbol>(getSectionSymbol(Reloc.Index))) {
+      return Sym->Section->OutputOffset + Reloc.Addend;
----------------
No need for this cast anymore, or the `if` I guess


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45118





More information about the llvm-commits mailing list