[PATCH] D45841: Keep the output text sections with prefixes ".text.hot" , ".text.unlikely", ".text.startup", ".text.exit" separate

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 4 11:31:01 PDT 2018


grimar added inline comments.


================
Comment at: test/ELF/text-section-prefix.s:5
+# RUN: ld.lld -z keep-text-section-prefix -z nokeep-text-section-prefix %t -o %t3
+# RUN: llvm-readelf -l %t3 | FileCheck --check-prefix=CHECK-TEXT --check-prefix=CHECKNO %s
+
----------------
I think it is a bit overcomplicated.

Can you just add 2 cases here please:
1) No any flags.
2) Case with -z nokeep-text-section-prefix.

Them should be the same. And I think the following should work:

# CHECKNO: .text
# CHECKNO-NOT: .text



https://reviews.llvm.org/D45841





More information about the llvm-commits mailing list