[PATCH] D46010: [AArch64] Improve cost of vector division by constant

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz updated this revision to Diff 145223.
zatrazz added a comment.

But I do agree that there is not much gain in making the division by constant cost logic generic. I changed by moving the logic on aarch64 target cost class.


https://reviews.llvm.org/D46010

Files:
  lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  test/Analysis/CostModel/AArch64/div_cte.ll


Index: test/Analysis/CostModel/AArch64/div_cte.ll
===================================================================
--- /dev/null
+++ test/Analysis/CostModel/AArch64/div_cte.ll
@@ -0,0 +1,45 @@
+; RUN: opt -cost-model -analyze -mtriple=aarch64-linux-gnu -mattr=+neon < %s | FileCheck %s
+
+; Verify the cost of integer division by constant.
+
+define <16 x i8> @sdiv8xi16(<16 x i8> %x) {
+; CHECK-LABEL: 'Cost Model Analysis' for function 'sdiv8xi16':
+; CHECK: Found an estimated cost of 9 for instruction: %div = sdiv <16 x i8> %x, <i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9>
+  %div = sdiv <16 x i8> %x, <i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9>
+  ret <16 x i8> %div
+}
+
+define <8 x i16> @sdiv16xi8(<8 x i16> %x) {
+; CHECK-LABEL: 'Cost Model Analysis' for function 'sdiv16xi8':
+; CHECK: Found an estimated cost of 9 for instruction: %div = sdiv <8 x i16> %x, <i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9>
+  %div = sdiv <8 x i16> %x, <i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9>
+  ret <8 x i16> %div
+}
+
+define <4 x i32> @sdiv32xi4(<4 x i32> %x) {
+; CHECK-LABEL: 'Cost Model Analysis' for function 'sdiv32xi4':
+; CHECK: Found an estimated cost of 9 for instruction: %div = sdiv <4 x i32> %x, <i32 9, i32 9, i32 9, i32 9>
+  %div = sdiv <4 x i32> %x, <i32 9, i32 9, i32 9, i32 9>
+  ret <4 x i32> %div
+}
+
+define <16 x i8> @udiv8xi16(<16 x i8> %x) {
+; CHECK-LABEL: 'Cost Model Analysis' for function 'udiv8xi16':
+; CHECK: Found an estimated cost of 9 for instruction: %div = udiv <16 x i8> %x, <i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9>
+  %div = udiv <16 x i8> %x, <i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9, i8 9>
+  ret <16 x i8> %div
+}
+
+define <8 x i16> @udiv16xi8(<8 x i16> %x) {
+; CHECK-LABEL: 'Cost Model Analysis' for function 'udiv16xi8':
+; CHECK: Found an estimated cost of 9 for instruction:   %div = udiv <8 x i16> %x, <i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9>
+  %div = udiv <8 x i16> %x, <i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9, i16 9>
+  ret <8 x i16> %div
+}
+
+define <4 x i32> @udiv32xi4(<4 x i32> %x) {
+; CHECK-LABEL: Printing analysis 'Cost Model Analysis' for function 'udiv32xi4':
+; CHECK: Found an estimated cost of 9 for instruction:   %div = udiv <4 x i32> %x, <i32 9, i32 9, i32 9, i32 9>
+  %div = udiv <4 x i32> %x, <i32 9, i32 9, i32 9, i32 9>
+  ret <4 x i32> %div
+}
Index: lib/Target/AArch64/AArch64TargetTransformInfo.cpp
===================================================================
--- lib/Target/AArch64/AArch64TargetTransformInfo.cpp
+++ lib/Target/AArch64/AArch64TargetTransformInfo.cpp
@@ -474,6 +474,7 @@
   return ST->getVectorInsertExtractBaseCost();
 }
 
+
 int AArch64TTIImpl::getArithmeticInstrCost(
     unsigned Opcode, Type *Ty, TTI::OperandValueKind Opd1Info,
     TTI::OperandValueKind Opd2Info, TTI::OperandValueProperties Opd1PropInfo,
@@ -520,6 +521,28 @@
     }
     LLVM_FALLTHROUGH;
   case ISD::UDIV:
+    if (Opd2Info == TargetTransformInfo::OK_UniformConstantValue) {
+      auto VT = TLI->getValueType(DL, Ty);
+      if (TLI->isOperationLegalOrCustom(ISD::MULHU, VT)) {
+        // Vector signed division by constant are expanded to the
+        // sequence MULHS + ADD/SUB + SRA + SRL + ADD, and unsigned division
+        // to MULHS + SUB + SRL + ADD + SRL.
+        int MulCost = getArithmeticInstrCost(Instruction::Mul, Ty, Opd1Info,
+                                             Opd2Info,
+                                             TargetTransformInfo::OP_None,
+                                             TargetTransformInfo::OP_None);
+        int AddCost = getArithmeticInstrCost(Instruction::Add, Ty, Opd1Info,
+                                             Opd2Info,
+                                             TargetTransformInfo::OP_None,
+                                             TargetTransformInfo::OP_None);
+        int ShrCost = getArithmeticInstrCost(Instruction::AShr, Ty, Opd1Info,
+                                             Opd2Info,
+                                             TargetTransformInfo::OP_None,
+                                             TargetTransformInfo::OP_None);
+        return MulCost * 2 + AddCost * 2 + ShrCost * 2 + 1;
+      }
+    }
+
     Cost += BaseT::getArithmeticInstrCost(Opcode, Ty, Opd1Info, Opd2Info,
                                           Opd1PropInfo, Opd2PropInfo);
     if (Ty->isVectorTy()) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D46010.145223.patch
Type: text/x-patch
Size: 4626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180504/a3b9804b/attachment.bin>