[PATCH] D46366: AMDGPU: Add D16 instructions preserve unused bits feature

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM. Adding run lines with a target without the feature to the assembler/disassembler tests wouldn't hurt



================
Comment at: lib/Target/AMDGPU/AMDGPU.td:319-323
+def FeatureD16HIInsts : SubtargetFeature<"d16-hi-insts",
+  "HasD16HIInsts",
+  "true",
+  "Has D16_HI instructions"
+>;
----------------
kzhuravl wrote:
> arsenm wrote:
> > arsenm wrote:
> > > This isn't the right to handle this. The instructions themselves do exist, so should not be dependent on a subtarget feature. The assembler/disassembler should still accept them. This should be a separately named feature
> > We also still can select them, just under different circumstances
> Can this be done in a separate change?
As far as selecting them, yes


https://reviews.llvm.org/D46366