[PATCH] D46246: [XRay][compiler-rt] Support string-based config for Basic mode.

[Keith via Phabricator via llvm-commits]

kpw accepted this revision.
kpw added inline comments.
This revision is now accepted and ready to land.


================
Comment at: compiler-rt/lib/xray/xray_basic_flags.cc:25
+
+BasicFlags xray_basic_flags_dont_use_directly; // use via basicFlags().
+
----------------
Can you make this a Doxygen comment?


================
Comment at: compiler-rt/lib/xray/xray_basic_logging.cc:400
+    P.ParseString(EnvOpts);
+    if (internal_strlen(EnvOpts) == 0) {
+      F.func_duration_threshold_us =
----------------
Shoudn't this be != 0? Override the defaults if XRAY_BASIC_OPTIONS was not empty?


https://reviews.llvm.org/D46246