[PATCH] D46338: [GlobalISel][Legalizer] LegalizerInfo verifier: checking that legalization rules cover all type indices

[Roman Tereshin via Phabricator via llvm-commits]

rtereshin added inline comments.


================
Comment at: test/CodeGen/AArch64/GlobalISel/legalize-inttoptr-xfail-1.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64-- -run-pass=legalizer -simplify-mir %s -o - 2>&1 | FileCheck %s
+
----------------
qcolombet wrote:
> Could you add a comment explaining what you are testing in this test case?
> Basically why is it useful? :)
> 
> Shouldn't we run `not llc`?
It's useful because it makes it obvious what kind of bugs we're missing w/o some kind of validation for LegalizerInfo. I guess I should add a comment saying exactly that :)

And the test passes, that's the point. So no `not llc`. Or you want `not llc` **and** `XFAIL` both in the same file?


Repository:
  rL LLVM

https://reviews.llvm.org/D46338