[PATCH] D45948: [MIRParser] Allow register class names in the form of integer/scalar

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 14:23:43 PDT 2018


aheejin marked an inline comment as done.
aheejin added a comment.

Thank you for the reviews!



================
Comment at: lib/CodeGen/MIRParser/MIParser.cpp:1307
+  if (Token.range().front() == 's' || Token.range().front() == 'p')
+    for (auto C : Token.range().drop_front())
+      if (!isdigit(C))
----------------
thegameg wrote:
> Can we refactor this into a function?
I reduced the repeating to code to a single line. Would it still be better to factor it out?


Repository:
  rL LLVM

https://reviews.llvm.org/D45948





More information about the llvm-commits mailing list