[PATCH] D46384: Reapply "[SelectionDAG] Selection of DBG_VALUE using a PHI node result (pt 2)"

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 3 11:29:18 PDT 2018


vsk added inline comments.


================
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5282
+              if (Offset >= BitsToDescribe)
+                break;
+              unsigned FragmentSize = (Offset + RegisterSize > BitsToDescribe)
----------------
Just curious -- could this be simplified to 'assert(Offset <= BitsToDescribe)'?


Repository:
  rL LLVM

https://reviews.llvm.org/D46384





More information about the llvm-commits mailing list