[PATCH] D45788: Mitigate relocation overflow [part 1 of 2]

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

Few comments for now + please upload the patch with the context (just read the https://llvm.org/docs/Phabricator.html).



================
Comment at: test/ELF/basic-ppc.s:15
 // CHECK-NEXT: AddressSize: 32bit
-// CHECK-NEXT: LoadName:
+// CHECK-NEXT: LoadName: 
 // CHECK-NEXT: ElfHeader {
----------------
Remove trailing whitespace, please.


================
Comment at: test/ELF/basic-ppc.s:60
 // CHECK-NEXT:     Index: 1
-// CHECK-NEXT:     Name: .dynsym
+// CHECK-NEXT:     Name: .dynsym (1)
 // CHECK-NEXT:     Type: SHT_DYNSYM (0xB)
----------------
`(1)` is new and excessive. The same issues below.


================
Comment at: test/ELF/dynsec-at-beginning.s:13
+# CHECK-NEXT: .hash    {{.*}}   A
+# CHECK-NEXT: .text    {{.*}}   A
 
----------------
.text is `AX` please keep the full attributes name.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D45788