[PATCH] D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 19:21:15 PDT 2018


mkazantsev added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:8797
+
+  if (isKnownPredicateViaSplitting(Pred, LHS, RHS))
+    return true;
----------------
This can invoke `isKnownPredicate` and `isKnownViaInduction` from inside. And we will have the same problem again. I suggest invoking non-recursive reasoning check from umax/smax.


https://reviews.llvm.org/D46046





More information about the llvm-commits mailing list