[llvm] r331402 - [llvm-cvtres] Allow parameters preceded by '-' in addition to '/'

Martin Storsjo via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 14:15:13 PDT 2018


Author: mstorsjo
Date: Wed May  2 14:15:13 2018
New Revision: 331402

URL: http://llvm.org/viewvc/llvm-project?rev=331402&view=rev
Log:
[llvm-cvtres] Allow parameters preceded by '-' in addition to '/'

The real cvtres.exe also allows parameters in either form.

Differential Revision: https://reviews.llvm.org/D46358

Modified:
    llvm/trunk/test/tools/llvm-cvtres/symbols.test
    llvm/trunk/tools/llvm-cvtres/Opts.td

Modified: llvm/trunk/test/tools/llvm-cvtres/symbols.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/llvm-cvtres/symbols.test?rev=331402&r1=331401&r2=331402&view=diff
==============================================================================
--- llvm/trunk/test/tools/llvm-cvtres/symbols.test (original)
+++ llvm/trunk/test/tools/llvm-cvtres/symbols.test Wed May  2 14:15:13 2018
@@ -10,6 +10,10 @@
 RUN: llvm-cvtres /verbose /out:%t %p/Inputs/test_resource.res
 RUN: llvm-readobj -symbols %t | FileCheck %s
 
+// Test that parameters can be preceded by '-' in addition to '/':
+RUN: llvm-cvtres -verbose -machine:X86 -out:%t %p/Inputs/test_resource.res
+RUN: llvm-readobj -symbols %t | FileCheck %s
+
 CHECK:        Name: $R000000
 CHECK-NEXT:    Value: 0
 CHECK-NEXT:    Section: .rsrc$02

Modified: llvm/trunk/tools/llvm-cvtres/Opts.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-cvtres/Opts.td?rev=331402&r1=331401&r2=331402&view=diff
==============================================================================
--- llvm/trunk/tools/llvm-cvtres/Opts.td (original)
+++ llvm/trunk/tools/llvm-cvtres/Opts.td Wed May  2 14:15:13 2018
@@ -1,11 +1,13 @@
 include "llvm/Option/OptParser.td"
 
-def DEFINE : Joined<["/"], "DEFINE:">, HelpText<"">, MetaVarName<"symbol">;
-def FOLDDUPS : Flag<["/"], "FOLDDUPS:">, HelpText<"">;
-def MACHINE : Joined<["/"], "MACHINE:">, HelpText<"">, MetaVarName<"{ARM|ARM64|EBC|IA64|X64|X86}">;
-def NOLOGO : Flag<["/"], "NOLOGO">, HelpText<"">;
-def OUT : Joined<["/"], "OUT:">, HelpText<"">, MetaVarName<"filename">;
-def READONLY : Flag<["/"], "READONLY">, HelpText<"">;
-def VERBOSE : Flag<["/"], "VERBOSE">, HelpText<"">;
-def HELP : Flag<["/"], "HELP">;
-def H : Flag<["/"], "H">, Alias<HELP>;
+// All the switches can be preceded by either '/' or '-'.
+
+def DEFINE : Joined<["/", "-"], "DEFINE:">, HelpText<"">, MetaVarName<"symbol">;
+def FOLDDUPS : Flag<["/", "-"], "FOLDDUPS:">, HelpText<"">;
+def MACHINE : Joined<["/", "-"], "MACHINE:">, HelpText<"">, MetaVarName<"{ARM|ARM64|EBC|IA64|X64|X86}">;
+def NOLOGO : Flag<["/", "-"], "NOLOGO">, HelpText<"">;
+def OUT : Joined<["/", "-"], "OUT:">, HelpText<"">, MetaVarName<"filename">;
+def READONLY : Flag<["/", "-"], "READONLY">, HelpText<"">;
+def VERBOSE : Flag<["/", "-"], "VERBOSE">, HelpText<"">;
+def HELP : Flag<["/", "-"], "HELP">;
+def H : Flag<["/", "-"], "H">, Alias<HELP>;




More information about the llvm-commits mailing list