[PATCH] D46217: [llvm-objcopy] Add --weaken option

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D46217#1085019, @paulsemel wrote:

> In https://reviews.llvm.org/D46217#1084850, @jakehehrlich wrote:
>
> > I'm happy with this change. I think we should change --globalize and --localize to match but if --globalize-symbol or --localize-symbol is used it shouldn't bother checking; if people want to do non-sense that's their choice. I didn't think about it but it makes a lot of sense not to globalize weak symbols and it makes sense to not localize undefined symbols. So I think the choices objcopy chose makes sense. If you could change those to match that, it would be awesome!
>
>
> Cool, nice to hear ! However, I don't think there is `--globalize` and `--localize` option implemented.. so I don't really see what you want me to change


I have an imaginative memory apparently. For some reason I thought you implemented those. Whoops. LGTM on this


Repository:
  rL LLVM

https://reviews.llvm.org/D46217