[PATCH] D46348: [SelectionDAG] Transfer DbgValues when casts are optimized in SelectionDAG::getNode

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 11:07:34 PDT 2018


vsk requested changes to this revision.
vsk added a comment.
This revision now requires changes to proceed.

Thanks for the patch! Could you upload a diff with context (git diff -U10000)?



================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3969
+      if (OpOp.getValueType() == VT) {
+        transferDbgValues(Operand, OpOp, 0, 0, false);
         return OpOp;
----------------
Why is InvalidateDbg false? Does the debug value attached to Operand need to remain valid after it's cloned and attached to OpOp?


Repository:
  rL LLVM

https://reviews.llvm.org/D46348





More information about the llvm-commits mailing list