[PATCH] D45734: [reassociate] Fix excessive revisits when processing long chains of reassociatable instructions.

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 09:48:09 PDT 2018


dsanders added a comment.

Thanks



================
Comment at: test/Transforms/Reassociate/long-chains.ll:31
+; CHECK: 55 reassociate - Number of insts reassociated
+; CHECK:  3 reassociate - Number of multiplies factored
----------------
dberlin wrote:
> Is it possible to check the number of visits is within a range?
> 
> (IE 100-200, and not 1 million)?
> 
> I don't remember if lit can do this :(
I don't think it can do ranges but orders of magnitude are possible by matching a fixed number of digits with something like:
  ; CHECK: {{[1-9][0-9]}} reassociate - Number of insts reassociated
Would you like me to change it to that?


Repository:
  rL LLVM

https://reviews.llvm.org/D45734





More information about the llvm-commits mailing list