[PATCH] D46288: Don't redefine a bunch of defines from llvm-config.h in config.h.

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

bogner, rnk, chapuni: ping



================
Comment at: include/llvm/Config/config.h.cmake:296-297
-/* Target triple LLVM will generate code for by default */
-/* Doesn't use `cmakedefine` because it is allowed to be empty. */
-#define LLVM_DEFAULT_TARGET_TRIPLE "${LLVM_DEFAULT_TARGET_TRIPLE}"
-
----------------
thakis wrote:
> bogner wrote:
> > The one in llvm-config.h doesn't have this comment and does use cmakedefine. Please make sure we're still doing the right thing when this is empty (that is, build with -DLLVM_DEFAULT_TARGET_TRIPLE="")
> Since config.h includes llvm-config.h, when it's undefined in config.h the one in llvm-config.h won. So this is behavior-preserving, and since this doesn't work it looks like the comment is outdated.
Did this make sense?


https://reviews.llvm.org/D46288