[PATCH] D46356: [TableGen] Emit a fatal error on inconsistencies in resource units vs cycles.

Javed Absar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 2 07:35:52 PDT 2018


javed.absar added a comment.

Thanks for this check. 
If ResourceCycles is not specified then it should default to 1 . I believe most people write with that interpretation.
If ResourceCycles is specified for at least one resource, it makes sense from correctness POV that it be specified for all (even though it might get verbose at time).


Repository:
  rL LLVM

https://reviews.llvm.org/D46356





More information about the llvm-commits mailing list